Checkstyle Results

The following document contains the results of Checkstyle 5.7. rss feed

Summary

Files  Info  Warnings  Errors
11 0 0 264

Files

File  I  W  E
com/github/davidmoten/security/Bytes.java 0 0 5
com/github/davidmoten/security/BytesTest.java 0 0 7
com/github/davidmoten/security/Classpath.java 0 0 7
com/github/davidmoten/security/ClasspathTest.java 0 0 9
com/github/davidmoten/security/InputTooLongException.java 0 0 10
com/github/davidmoten/security/PPK.java 0 0 202
com/github/davidmoten/security/PPKTest.java 0 0 2
com/github/davidmoten/security/Preconditions.java 0 0 8
com/github/davidmoten/security/PreconditionsTest.java 0 0 9
com/github/davidmoten/security/PrivateKeyNotSetException.java 0 0 3
com/github/davidmoten/security/PublicKeyNotSetException.java 0 0 2

Rules

Category Rule Violations Severity
blocks NeedBraces 5  Error
coding HiddenField 4  Error
MagicNumber 5  Error
design DesignForExtension 11  Error
VisibilityModifier 4  Error
javadoc JavadocMethod 75  Error
JavadocPackage
  • allowLegacy: "true"
 2  Error
JavadocType 11  Error
JavadocVariable 19  Error
misc FinalParameters 91  Error
modifier RedundantModifier 10  Error
regexp RegexpSingleline
  • format: "\s+$"
  • message: "Line has trailing spaces."
 8  Error
sizes LineLength 12  Error
whitespace FileTabCharacter
  • eachLine: "true"
 5  Error
WhitespaceAfter 1  Error

Details

com/github/davidmoten/security/Bytes.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 7
 Error javadoc JavadocMethod Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 13
 Error misc FinalParameters Parameter is should be final. 13
 Error coding MagicNumber '1024' is a magic number. 17

com/github/davidmoten/security/BytesTest.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 12
 Error design DesignForExtension Method 'testIsUtilClass' is not designed for extension - needs to be abstract, final or empty. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error design DesignForExtension Method 'testNullInputStream' is not designed for extension - needs to be abstract, final or empty. 19
 Error javadoc JavadocMethod Missing a Javadoc comment. 19
 Error design DesignForExtension Method 'testRead' is not designed for extension - needs to be abstract, final or empty. 24
 Error javadoc JavadocMethod Missing a Javadoc comment. 24

com/github/davidmoten/security/Classpath.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 5
 Error javadoc JavadocMethod Missing a Javadoc comment. 7
 Error javadoc JavadocMethod Missing a Javadoc comment. 11
 Error misc FinalParameters Parameter cls should be final. 11
 Error misc FinalParameters Parameter resource should be final. 11
 Error javadoc JavadocMethod Missing a Javadoc comment. 16
 Error misc FinalParameters Parameter is should be final. 16

com/github/davidmoten/security/ClasspathTest.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 13
 Error design DesignForExtension Method 'testFound' is not designed for extension - needs to be abstract, final or empty. 15
 Error javadoc JavadocMethod Missing a Javadoc comment. 15
 Error design DesignForExtension Method 'testNotFound' is not designed for extension - needs to be abstract, final or empty. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 21
 Error design DesignForExtension Method 'testIOExceptionFromInputStreamThrows' is not designed for extension - needs to be abstract, final or empty. 26
 Error javadoc JavadocMethod Missing a Javadoc comment. 26
 Error design DesignForExtension Method 'testIsUtilityClass' is not designed for extension - needs to be abstract, final or empty. 37
 Error javadoc JavadocMethod Missing a Javadoc comment. 37

com/github/davidmoten/security/InputTooLongException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error whitespace FileTabCharacter Line contains a tab character. 5
 Error javadoc JavadocVariable Missing a Javadoc comment. 5
 Error regexp RegexpSingleline Line has trailing spaces. 6
 Error whitespace FileTabCharacter Line contains a tab character. 6
 Error whitespace FileTabCharacter Line contains a tab character. 7
 Error javadoc JavadocMethod Missing a Javadoc comment. 7
 Error misc FinalParameters Parameter message should be final. 7
 Error whitespace FileTabCharacter Line contains a tab character. 8
 Error whitespace FileTabCharacter Line contains a tab character. 9

com/github/davidmoten/security/PPK.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 85). 52
 Error javadoc JavadocVariable Missing a Javadoc comment. 52
 Error javadoc JavadocVariable Missing a Javadoc comment. 53
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error javadoc JavadocVariable Missing a Javadoc comment. 55
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 55
 Error javadoc JavadocVariable Missing a Javadoc comment. 56
 Error coding MagicNumber '8' is a magic number. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 58
 Error javadoc JavadocVariable Missing a Javadoc comment. 59
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error javadoc JavadocType Missing a Javadoc comment. 62
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error design VisibilityModifier Variable 'encodedSecretKey' must be private and have accessor methods. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error design VisibilityModifier Variable 'secretKeySpec' must be private and have accessor methods. 67
 Error javadoc JavadocVariable Missing a Javadoc comment. 70
 Error design VisibilityModifier Variable 'cipher' must be private and have accessor methods. 70
 Error javadoc JavadocVariable Missing a Javadoc comment. 72
 Error design VisibilityModifier Variable 'rsaEncryptedSecretKeyBytes' must be private and have accessor methods. 72
 Error javadoc JavadocMethod Missing a Javadoc comment. 74
 Error misc FinalParameters Parameter publicCipher should be final. 74
 Error sizes LineLength Line is longer than 80 characters (found 83). 84
 Error blocks NeedBraces 'if' construct must use '{}'s. 85
 Error coding MagicNumber '256' is a magic number. 85
 Error sizes LineLength Line is longer than 80 characters (found 96). 87
 Error blocks NeedBraces 'else' construct must use '{}'s. 88
 Error sizes LineLength Line is longer than 80 characters (found 96). 97
 Error javadoc JavadocMethod Missing a Javadoc comment. 97
 Error misc FinalParameters Parameter publicCipher should be final. 97
 Error coding HiddenField 'publicCipher' hides a field. 97
 Error misc FinalParameters Parameter privateCipher should be final. 97
 Error coding HiddenField 'privateCipher' hides a field. 97
 Error misc FinalParameters Parameter unique should be final. 97
 Error coding HiddenField 'unique' hides a field. 97
 Error regexp RegexpSingleline Line has trailing spaces. 107
 Error modifier RedundantModifier Redundant 'final' modifier. 114
 Error misc FinalParameters Parameter cls should be final. 114
 Error misc FinalParameters Parameter resource should be final. 114
 Error regexp RegexpSingleline Line has trailing spaces. 121
 Error modifier RedundantModifier Redundant 'final' modifier. 126
 Error misc FinalParameters Parameter resource should be final. 126
 Error regexp RegexpSingleline Line has trailing spaces. 133
 Error modifier RedundantModifier Redundant 'final' modifier. 138
 Error misc FinalParameters Parameter is should be final. 138
 Error regexp RegexpSingleline Line has trailing spaces. 144
 Error modifier RedundantModifier Redundant 'final' modifier. 149
 Error misc FinalParameters Parameter file should be final. 149
 Error regexp RegexpSingleline Line has trailing spaces. 156
 Error modifier RedundantModifier Redundant 'final' modifier. 161
 Error misc FinalParameters Parameter bytes should be final. 161
 Error regexp RegexpSingleline Line has trailing spaces. 168
 Error modifier RedundantModifier Redundant 'final' modifier. 175
 Error misc FinalParameters Parameter cls should be final. 175
 Error misc FinalParameters Parameter resource should be final. 175
 Error regexp RegexpSingleline Line has trailing spaces. 182
 Error modifier RedundantModifier Redundant 'final' modifier. 187
 Error misc FinalParameters Parameter resource should be final. 187
 Error javadoc JavadocMethod Missing a Javadoc comment. 191
 Error modifier RedundantModifier Redundant 'final' modifier. 191
 Error misc FinalParameters Parameter file should be final. 191
 Error javadoc JavadocMethod Missing a Javadoc comment. 195
 Error modifier RedundantModifier Redundant 'final' modifier. 195
 Error misc FinalParameters Parameter is should be final. 195
 Error javadoc JavadocMethod Missing a Javadoc comment. 199
 Error modifier RedundantModifier Redundant 'final' modifier. 199
 Error misc FinalParameters Parameter bytes should be final. 199
 Error javadoc JavadocType Missing a Javadoc comment. 203
 Error javadoc JavadocVariable Missing a Javadoc comment. 204
 Error javadoc JavadocVariable Missing a Javadoc comment. 205
 Error javadoc JavadocVariable Missing a Javadoc comment. 206
 Error javadoc JavadocMethod Missing a Javadoc comment. 208
 Error javadoc JavadocMethod Missing a Javadoc comment. 212
 Error misc FinalParameters Parameter is should be final. 212
 Error javadoc JavadocMethod Missing a Javadoc comment. 217
 Error misc FinalParameters Parameter is should be final. 217
 Error javadoc JavadocMethod Missing a Javadoc comment. 222
 Error misc FinalParameters Parameter bytes should be final. 222
 Error javadoc JavadocMethod Missing a Javadoc comment. 228
 Error misc FinalParameters Parameter resource should be final. 228
 Error javadoc JavadocMethod Missing a Javadoc comment. 233
 Error misc FinalParameters Parameter cls should be final. 233
 Error misc FinalParameters Parameter resource should be final. 233
 Error javadoc JavadocMethod Missing a Javadoc comment. 239
 Error misc FinalParameters Parameter file should be final. 239
 Error javadoc JavadocMethod Missing a Javadoc comment. 248
 Error misc FinalParameters Parameter bytes should be final. 248
 Error javadoc JavadocMethod Missing a Javadoc comment. 254
 Error misc FinalParameters Parameter resource should be final. 254
 Error javadoc JavadocMethod Missing a Javadoc comment. 259
 Error misc FinalParameters Parameter cls should be final. 259
 Error misc FinalParameters Parameter resource should be final. 259
 Error javadoc JavadocMethod Missing a Javadoc comment. 265
 Error misc FinalParameters Parameter file should be final. 265
 Error javadoc JavadocMethod Missing a Javadoc comment. 274
 Error misc FinalParameters Parameter bytes should be final. 274
 Error javadoc JavadocMethod Missing a Javadoc comment. 278
 Error misc FinalParameters Parameter is should be final. 278
 Error javadoc JavadocMethod Missing a Javadoc comment. 282
 Error misc FinalParameters Parameter bytes should be final. 282
 Error javadoc JavadocMethod Missing a Javadoc comment. 286
 Error misc FinalParameters Parameter string should be final. 286
 Error misc FinalParameters Parameter charset should be final. 286
 Error javadoc JavadocMethod Missing a Javadoc comment. 290
 Error misc FinalParameters Parameter bytes should be final. 290
 Error javadoc JavadocMethod Missing a Javadoc comment. 294
 Error misc FinalParameters Parameter string should be final. 294
 Error misc FinalParameters Parameter charset should be final. 294
 Error javadoc JavadocMethod Missing a Javadoc comment. 298
 Error misc FinalParameters Parameter string should be final. 298
 Error javadoc JavadocMethod Missing a Javadoc comment. 302
 Error misc FinalParameters Parameter string should be final. 302
 Error javadoc JavadocMethod Missing a Javadoc comment. 306
 Error misc FinalParameters Parameter bytes should be final. 306
 Error misc FinalParameters Parameter charset should be final. 306
 Error javadoc JavadocMethod Missing a Javadoc comment. 310
 Error misc FinalParameters Parameter bytes should be final. 310
 Error javadoc JavadocMethod Missing a Javadoc comment. 314
 Error misc FinalParameters Parameter bytes should be final. 314
 Error misc FinalParameters Parameter charset should be final. 314
 Error javadoc JavadocMethod Missing a Javadoc comment. 318
 Error misc FinalParameters Parameter base64 should be final. 318
 Error javadoc JavadocMethod Missing a Javadoc comment. 322
 Error misc FinalParameters Parameter base64 should be final. 322
 Error javadoc JavadocMethod Missing a Javadoc comment. 326
 Error misc FinalParameters Parameter is should be final. 326
 Error misc FinalParameters Parameter os should be final. 326
 Error javadoc JavadocMethod Missing a Javadoc comment. 330
 Error misc FinalParameters Parameter is should be final. 330
 Error misc FinalParameters Parameter os should be final. 330
 Error javadoc JavadocMethod Missing a Javadoc comment. 334
 Error misc FinalParameters Parameter value should be final. 334
 Error javadoc JavadocMethod Missing a Javadoc comment. 339
 Error javadoc JavadocMethod Missing a Javadoc comment. 343
 Error javadoc JavadocMethod Missing a Javadoc comment. 349
 Error misc FinalParameters Parameter is should be final. 349
 Error misc FinalParameters Parameter os should be final. 349
 Error coding HiddenField 'aes' hides a field. 354
 Error blocks NeedBraces 'else' construct must use '{}'s. 366
 Error javadoc JavadocMethod Missing a Javadoc comment. 370
 Error misc FinalParameters Parameter string should be final. 370
 Error javadoc JavadocMethod Missing a Javadoc comment. 374
 Error misc FinalParameters Parameter base64 should be final. 374
 Error javadoc JavadocMethod Missing a Javadoc comment. 378
 Error misc FinalParameters Parameter is should be final. 378
 Error javadoc JavadocMethod Missing a Javadoc comment. 383
 Error misc FinalParameters Parameter bytes should be final. 383
 Error sizes LineLength Line is longer than 80 characters (found 92). 394
 Error javadoc JavadocMethod Missing a Javadoc comment. 394
 Error misc FinalParameters Parameter aes should be final. 394
 Error misc FinalParameters Parameter is should be final. 394
 Error misc FinalParameters Parameter os should be final. 394
 Error javadoc JavadocMethod Missing a Javadoc comment. 405
 Error misc FinalParameters Parameter is should be final. 405
 Error misc FinalParameters Parameter os should be final. 405
 Error sizes LineLength Line is longer than 80 characters (found 96). 418
 Error sizes LineLength Line is longer than 80 characters (found 99). 421
 Error blocks NeedBraces 'else' construct must use '{}'s. 434
 Error javadoc JavadocMethod Missing a Javadoc comment. 438
 Error misc FinalParameters Parameter bytes should be final. 438
 Error javadoc JavadocMethod Missing a Javadoc comment. 449
 Error misc FinalParameters Parameter string should be final. 449
 Error misc FinalParameters Parameter charset should be final. 449
 Error javadoc JavadocMethod Missing a Javadoc comment. 455
 Error misc FinalParameters Parameter bytes should be final. 455
 Error misc FinalParameters Parameter charset should be final. 455
 Error javadoc JavadocMethod Missing a Javadoc comment. 461
 Error misc FinalParameters Parameter bytes should be final. 461
 Error coding MagicNumber '214' is a magic number. 463
 Error sizes LineLength Line is longer than 80 characters (found 122). 465
 Error javadoc JavadocMethod Missing a Javadoc comment. 470
 Error misc FinalParameters Parameter bytes should be final. 470
 Error javadoc JavadocMethod Missing a Javadoc comment. 475
 Error misc FinalParameters Parameter string should be final. 475
 Error misc FinalParameters Parameter charset should be final. 475
 Error javadoc JavadocMethod Missing a Javadoc comment. 481
 Error misc FinalParameters Parameter string should be final. 481
 Error javadoc JavadocMethod Missing a Javadoc comment. 485
 Error misc FinalParameters Parameter bytes should be final. 485
 Error misc FinalParameters Parameter charset should be final. 485
 Error javadoc JavadocMethod Missing a Javadoc comment. 491
 Error misc FinalParameters Parameter base64 should be final. 491
 Error javadoc JavadocMethod Missing a Javadoc comment. 495
 Error misc FinalParameters Parameter bytes should be final. 495
 Error sizes LineLength Line is longer than 80 characters (found 92). 503
 Error javadoc JavadocMethod Missing a Javadoc comment. 509
 Error misc FinalParameters Parameter bytes should be final. 509
 Error sizes LineLength Line is longer than 80 characters (found 92). 517
 Error sizes LineLength Line is longer than 80 characters (found 85). 523
 Error javadoc JavadocMethod Missing a Javadoc comment. 523
 Error misc FinalParameters Parameter cipher should be final. 523
 Error misc FinalParameters Parameter is should be final. 523
 Error misc FinalParameters Parameter os should be final. 523
 Error javadoc JavadocMethod Missing a Javadoc comment. 531
 Error misc FinalParameters Parameter cipher should be final. 531
 Error misc FinalParameters Parameter bytes should be final. 531
 Error sizes LineLength Line is longer than 80 characters (found 82). 538
 Error javadoc JavadocMethod Missing a Javadoc comment. 538
 Error misc FinalParameters Parameter is should be final. 538
 Error misc FinalParameters Parameter os should be final. 538
 Error coding MagicNumber '1024' is a magic number. 540

com/github/davidmoten/security/PPKTest.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error extension TreeWalker Got an exception - expecting EOF, found 'assertEquals' 86

com/github/davidmoten/security/Preconditions.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error javadoc JavadocMethod Missing a Javadoc comment. 9
 Error misc FinalParameters Parameter o should be final. 9
 Error misc FinalParameters Parameter message should be final. 9
 Error blocks NeedBraces 'if' construct must use '{}'s. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error misc FinalParameters Parameter o should be final. 14

com/github/davidmoten/security/PreconditionsTest.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 10
 Error design DesignForExtension Method 'testCheckNotNullDoesNotThrowIfInputNotNull' is not designed for extension - needs to be abstract, final or empty. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error design DesignForExtension Method 'testCheckNotNullDoesThrowIfInputNull' is not designed for extension - needs to be abstract, final or empty. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error design DesignForExtension Method 'testCheckNotNullMessage' is not designed for extension - needs to be abstract, final or empty. 22
 Error javadoc JavadocMethod Missing a Javadoc comment. 22
 Error design DesignForExtension Method 'testIsUtilClass' is not designed for extension - needs to be abstract, final or empty. 32
 Error javadoc JavadocMethod Missing a Javadoc comment. 32

com/github/davidmoten/security/PrivateKeyNotSetException.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocVariable Missing a Javadoc comment. 5

com/github/davidmoten/security/PublicKeyNotSetException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocVariable Missing a Javadoc comment. 5