SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.8.6
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 43 |
14 |
0 |
0 |
com.github.davidmoten.aws.lw.client.Request
| Bug |
Category |
Details |
Line |
Priority |
| com.github.davidmoten.aws.lw.client.Request.requestBody(byte[]) may expose internal representation by storing an externally mutable object into Request.requestBody |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
| com.github.davidmoten.aws.lw.client.Request.calculateUrl(String, String, Optional, List, List, BaseUrlFactory) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
263 |
Medium |
com.github.davidmoten.aws.lw.client.RequestHelper
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in com.github.davidmoten.aws.lw.client.RequestHelper.parameter(String, String, String) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
205 |
Medium |
com.github.davidmoten.aws.lw.client.Response
| Bug |
Category |
Details |
Line |
Priority |
| com.github.davidmoten.aws.lw.client.Response.content() may expose internal representation by returning Response.content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
75 |
Medium |
| com.github.davidmoten.aws.lw.client.Response.headers() may expose internal representation by returning Response.headers |
MALICIOUS_CODE |
EI_EXPOSE_REP |
30 |
Medium |
| com.github.davidmoten.aws.lw.client.Response.headersLowerCaseKey() may expose internal representation by returning Response.headersLowerCaseKey |
MALICIOUS_CODE |
EI_EXPOSE_REP |
34 |
Medium |
| new com.github.davidmoten.aws.lw.client.Response(Map, byte[], int) may expose internal representation by storing an externally mutable object into Response.content |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
25 |
Medium |
| new com.github.davidmoten.aws.lw.client.Response(Map, byte[], int) may expose internal representation by storing an externally mutable object into Response.headers |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
23 |
Medium |
com.github.davidmoten.aws.lw.client.ResponseInputStream
| Bug |
Category |
Details |
Line |
Priority |
| com.github.davidmoten.aws.lw.client.ResponseInputStream.headers() may expose internal representation by returning ResponseInputStream.headers |
MALICIOUS_CODE |
EI_EXPOSE_REP |
56 |
Medium |
| new com.github.davidmoten.aws.lw.client.ResponseInputStream(Closeable, int, Map, InputStream) may expose internal representation by storing an externally mutable object into ResponseInputStream.headers |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
28 |
Medium |
| com.github.davidmoten.aws.lw.client.ResponseInputStream.header(String) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
62 |
Medium |
com.github.davidmoten.aws.lw.client.internal.EnvironmentDefault
| Bug |
Category |
Details |
Line |
Priority |
| com.github.davidmoten.aws.lw.client.internal.EnvironmentDefault.INSTANCE isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
6 |
High |
com.github.davidmoten.aws.lw.client.xml.XmlElement
| Bug |
Category |
Details |
Line |
Priority |
| com.github.davidmoten.aws.lw.client.xml.XmlElement.children() may expose internal representation by returning XmlElement.children |
MALICIOUS_CODE |
EI_EXPOSE_REP |
156 |
Medium |
| Switch statement found in com.github.davidmoten.aws.lw.client.xml.XmlElement.scanWhitespace(StringBuilder) where one case falls through to the next case |
STYLE |
SF_SWITCH_FALLTHROUGH |
486-488 |
Medium |
