Checkstyle Results

The following document contains the results of Checkstyle 8.29 with src/main/checkstyle/checkstyle.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
22 0 0 121

Files

File
 I
 W
 E
com/github/davidmoten/geo/Base32.java 0 0 14
com/github/davidmoten/geo/Base32Test.java 0 0 1
com/github/davidmoten/geo/Benchmarks.java 0 0 2
com/github/davidmoten/geo/Coverage.java 0 0 4
com/github/davidmoten/geo/CoverageLongs.java 0 0 4
com/github/davidmoten/geo/CoverageTest.java 0 0 6
com/github/davidmoten/geo/Direction.java 0 0 4
com/github/davidmoten/geo/GeoHash.java 0 0 50
com/github/davidmoten/geo/GeoHashTest.java 0 0 6
com/github/davidmoten/geo/LatLong.java 0 0 1
com/github/davidmoten/geo/TestingUtil.java 0 0 2
com/github/davidmoten/geo/db/DatabaseTest.java 0 0 11
com/github/davidmoten/geo/mem/Geomem.java 0 0 4
com/github/davidmoten/geo/mem/GeomemTest.java 0 0 5
com/github/davidmoten/geo/mem/Info.java 0 0 6
com/github/davidmoten/geo/util/Preconditions.java 0 0 1

Rules

Category Rule Violations Severity
blocks NeedBraces 57
 Error
RightCurly 3
 Error
coding InnerAssignment 1
 Error
MultipleVariableDeclarations 4
 Error
design DesignForExtension 11
 Error
HideUtilityClassConstructor 1
 Error
VisibilityModifier 2
 Error
javadoc JavadocMethod 2
 Error
JavadocPackage 2
 Error
JavadocStyle 3
 Error
misc ArrayTypeStyle 2
 Error
modifier ModifierOrder 2
 Error
RedundantModifier 1
 Error
naming ConstantName 8
 Error
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
6
 Error
whitespace FileTabCharacter 2
 Error
GenericWhitespace 8
 Error
NoWhitespaceAfter 2
 Error
WhitespaceAround 4
 Error

Details

com/github/davidmoten/geo/Base32.java

Severity Category Rule Message Line
 Error
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 23
 Error
naming ConstantName Name 'characters' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 23
 Error
whitespace NoWhitespaceAfter '{' is followed by whitespace. 23
 Error
modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 30
 Error
naming ConstantName Name 'characterIndexes' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 30
 Error
blocks NeedBraces 'for' construct must use '{}'s. 34
 Error
blocks NeedBraces 'if' construct must use '{}'s. 52
 Error
blocks NeedBraces 'if' construct must use '{}'s. 61
 Error
blocks NeedBraces 'else' construct must use '{}'s. 63
 Error
blocks NeedBraces 'if' construct must use '{}'s. 96
 Error
blocks NeedBraces 'if' construct must use '{}'s. 113
 Error
blocks NeedBraces 'else' construct must use '{}'s. 115
 Error
blocks NeedBraces 'for' construct must use '{}'s. 132
 Error
blocks NeedBraces 'else' construct must use '{}'s. 136

com/github/davidmoten/geo/Base32Test.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 17

com/github/davidmoten/geo/Benchmarks.java

Severity Category Rule Message Line
 Error
design DesignForExtension Class 'Benchmarks' looks like designed for extension (can be subclassed), but the method 'hashContains' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Benchmarks' final or making the method 'hashContains' static/final/abstract/empty, or adding allowed annotation for the method. 12
 Error
design DesignForExtension Class 'Benchmarks' looks like designed for extension (can be subclassed), but the method 'decodeHash' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Benchmarks' final or making the method 'decodeHash' static/final/abstract/empty, or adding allowed annotation for the method. 17

com/github/davidmoten/geo/Coverage.java

Severity Category Rule Message Line
 Error
whitespace WhitespaceAround 'for' is not followed by whitespace. 43
 Error
blocks NeedBraces 'if' construct must use '{}'s. 77
 Error
blocks NeedBraces 'else' construct must use '{}'s. 79
 Error
design DesignForExtension Class 'Coverage' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Coverage' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 83

com/github/davidmoten/geo/CoverageLongs.java

Severity Category Rule Message Line
 Error
modifier RedundantModifier Redundant 'public' modifier. 35
 Error
javadoc JavadocMethod Expected @param tag for 'count'. 35
 Error
blocks NeedBraces 'if' construct must use '{}'s. 73
 Error
blocks NeedBraces 'else' construct must use '{}'s. 75

com/github/davidmoten/geo/CoverageTest.java

Severity Category Rule Message Line
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 20
 Error
javadoc JavadocStyle First sentence should end with a period. 33
 Error
javadoc JavadocStyle First sentence should end with a period. 47
 Error
sizes LineLength Line is longer than 120 characters (found 197). 57
 Error
sizes LineLength Line is longer than 120 characters (found 197). 68
 Error
sizes LineLength Line is longer than 120 characters (found 122). 108

com/github/davidmoten/geo/Direction.java

Severity Category Rule Message Line
 Error
blocks NeedBraces 'if' construct must use '{}'s. 19
 Error
blocks NeedBraces 'if' construct must use '{}'s. 21
 Error
blocks NeedBraces 'if' construct must use '{}'s. 23
 Error
blocks NeedBraces 'else' construct must use '{}'s. 25

com/github/davidmoten/geo/GeoHash.java

Severity Category Rule Message Line
 Error
whitespace NoWhitespaceAfter '{' is followed by whitespace. 37
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 102
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 103
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 104
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 105
 Error
blocks NeedBraces 'if' construct must use '{}'s. 145
 Error
blocks NeedBraces 'if' construct must use '{}'s. 152
 Error
blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 169
 Error
blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 175
 Error
blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 181
 Error
blocks NeedBraces 'if' construct must use '{}'s. 260
 Error
blocks NeedBraces 'for' construct must use '{}'s. 264
 Error
whitespace WhitespaceAround '<=' is not followed by whitespace. 351
 Error
blocks NeedBraces 'if' construct must use '{}'s. 367
 Error
coding MultipleVariableDeclarations Each variable declaration must be in its own statement. 379
 Error
coding MultipleVariableDeclarations Each variable declaration must be in its own statement. 380
 Error
blocks NeedBraces 'else' construct must use '{}'s. 391
 Error
blocks NeedBraces 'else' construct must use '{}'s. 398
 Error
blocks NeedBraces 'if' construct must use '{}'s. 461
 Error
blocks NeedBraces 'else' construct must use '{}'s. 463
 Error
coding MultipleVariableDeclarations Each variable declaration must be in its own statement. 484
 Error
coding MultipleVariableDeclarations Each variable declaration must be in its own statement. 485
 Error
blocks NeedBraces 'if' construct must use '{}'s. 491
 Error
blocks NeedBraces 'if' construct must use '{}'s. 495
 Error
blocks NeedBraces 'if' construct must use '{}'s. 502
 Error
blocks NeedBraces 'if' construct must use '{}'s. 506
 Error
blocks NeedBraces 'if' construct must use '{}'s. 580
 Error
blocks NeedBraces 'if' construct must use '{}'s. 585
 Error
blocks NeedBraces 'else' construct must use '{}'s. 587
 Error
design VisibilityModifier Variable 'count' must be private and have accessor methods. 618
 Error
design VisibilityModifier Variable 'array' must be private and have accessor methods. 620
 Error
blocks NeedBraces 'for' construct must use '{}'s. 623
 Error
blocks NeedBraces 'if' construct must use '{}'s. 624
 Error
coding InnerAssignment Inner assignments should be avoided. 627
 Error
blocks NeedBraces 'if' construct must use '{}'s. 687
 Error
blocks NeedBraces 'else' construct must use '{}'s. 689
 Error
naming ConstantName Name 'values' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 695
 Error
misc ArrayTypeStyle Array brackets at illegal position. 698
 Error
blocks NeedBraces 'if' construct must use '{}'s. 715
 Error
blocks NeedBraces 'else' construct must use '{}'s. 717
 Error
naming ConstantName Name 'values' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 725
 Error
misc ArrayTypeStyle Array brackets at illegal position. 728
 Error
blocks NeedBraces 'if' construct must use '{}'s. 745
 Error
blocks NeedBraces 'else' construct must use '{}'s. 747
 Error
blocks NeedBraces 'if' construct must use '{}'s. 760
 Error
blocks NeedBraces 'else' construct must use '{}'s. 762
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 812
 Error
blocks NeedBraces 'if' construct must use '{}'s. 849
 Error
blocks NeedBraces 'if' construct must use '{}'s. 865
 Error
blocks NeedBraces 'else' construct must use '{}'s. 871

com/github/davidmoten/geo/GeoHashTest.java

Severity Category Rule Message Line
 Error
design DesignForExtension Class 'GeoHashTest' looks like designed for extension (can be subclassed), but the method 'testSpeed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GeoHashTest' final or making the method 'testSpeed' static/final/abstract/empty, or adding allowed annotation for the method. 205
 Error
blocks NeedBraces 'for' construct must use '{}'s. 208
 Error
sizes LineLength Line is longer than 120 characters (found 178). 325
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 489
 Error
whitespace WhitespaceAround '=' is not followed by whitespace. 616
 Error
whitespace WhitespaceAround '=' is not preceded with whitespace. 616

com/github/davidmoten/geo/LatLong.java

Severity Category Rule Message Line
 Error
design DesignForExtension Class 'LatLong' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LatLong' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 53

com/github/davidmoten/geo/TestingUtil.java

Severity Category Rule Message Line
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 15
 Error
javadoc JavadocMethod Expected @param tag for '<T>'. 23

com/github/davidmoten/geo/db/DatabaseTest.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 29
 Error
sizes LineLength Line is longer than 120 characters (found 164). 61
 Error
blocks NeedBraces 'while' construct must use '{}'s. 67
 Error
blocks NeedBraces 'if' construct must use '{}'s. 80
 Error
blocks NeedBraces 'if' construct must use '{}'s. 86
 Error
sizes LineLength Line is longer than 120 characters (found 242). 102
 Error
blocks NeedBraces 'if' construct must use '{}'s. 104
 Error
blocks NeedBraces 'else' construct must use '{}'s. 106
 Error
blocks NeedBraces 'for' construct must use '{}'s. 116
 Error
blocks NeedBraces 'for' construct must use '{}'s. 141
 Error
blocks NeedBraces 'if' construct must use '{}'s. 161

com/github/davidmoten/geo/mem/Geomem.java

Severity Category Rule Message Line
 Error
javadoc JavadocPackage Missing package-info.java file. 1
 Error
javadoc JavadocStyle Incomplete HTML tag found: * Returns the {@link Info}s where start<=time <finish and position is 139
 Error
blocks NeedBraces 'if' construct must use '{}'s. 153
 Error
blocks NeedBraces 'else' construct must use '{}'s. 155

com/github/davidmoten/geo/mem/GeomemTest.java

Severity Category Rule Message Line
 Error
naming ConstantName Name 'topLeftLat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 18
 Error
naming ConstantName Name 'topLeftLong' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 19
 Error
naming ConstantName Name 'bottomRightLat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 20
 Error
naming ConstantName Name 'bottomRightLong' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 21
 Error
whitespace GenericWhitespace '>' is followed by whitespace. 96

com/github/davidmoten/geo/mem/Info.java

Severity Category Rule Message Line
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'id' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'id' static/final/abstract/empty, or adding allowed annotation for the method. 21
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'lat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'lat' static/final/abstract/empty, or adding allowed annotation for the method. 25
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'lon' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'lon' static/final/abstract/empty, or adding allowed annotation for the method. 29
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'time' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'time' static/final/abstract/empty, or adding allowed annotation for the method. 33
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'value' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'value' static/final/abstract/empty, or adding allowed annotation for the method. 37
 Error
design DesignForExtension Class 'Info' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Info' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 41

com/github/davidmoten/geo/util/Preconditions.java

Severity Category Rule Message Line
 Error
javadoc JavadocPackage Missing package-info.java file. 1