Checkstyle Results

The following document contains the results of Checkstyle 6.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
6 0 0 293

Files

File  I  W  E
com/github/davidmoten/rx/FileObservable.java 0 0 166
com/github/davidmoten/rx/FileObservableTest.java 0 0 52
com/github/davidmoten/rx/SampleTest.java 0 0 8
com/github/davidmoten/rx/operators/OperatorFileTailer.java 0 0 32
com/github/davidmoten/rx/operators/OperatorFileTailerTest.java 0 0 3
com/github/davidmoten/rx/operators/OperatorWatchServiceEvents.java 0 0 32

Rules

Category Rule Violations Severity
blocks EmptyBlock 4  Error
NeedBraces 19  Error
coding HiddenField 11  Error
MagicNumber 22  Error
SimplifyBooleanReturn 1  Error
design DesignForExtension 9  Error
FinalClass 1  Error
HideUtilityClassConstructor 1  Error
javadoc JavadocMethod 48  Error
JavadocPackage 4  Error
JavadocType 4  Error
JavadocVariable 13  Error
misc FinalParameters 67  Error
modifier ModifierOrder 12  Error
RedundantModifier 9  Error
naming StaticVariableName 1  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 17  Error
sizes LineLength 50  Error

Details

com/github/davidmoten/rx/FileObservable.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error regexp RegexpSingleline Line has trailing spaces. 38
 Error javadoc JavadocMethod Expected an @return tag. 52
 Error sizes LineLength Line is longer than 80 characters (found 82). 52
 Error modifier RedundantModifier Redundant 'final' modifier. 52
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 52
 Error misc FinalParameters Parameter file should be final. 52
 Error misc FinalParameters Parameter startPosition should be final. 52
 Error misc FinalParameters Parameter sampleTimeMs should be final. 53
 Error misc FinalParameters Parameter chunkSize should be final. 53
 Error sizes LineLength Line is longer than 80 characters (found 84). 54
 Error sizes LineLength Line is longer than 80 characters (found 87). 55
 Error regexp RegexpSingleline Line has trailing spaces. 74
 Error javadoc JavadocMethod Expected an @return tag. 88
 Error sizes LineLength Line is longer than 80 characters (found 82). 88
 Error modifier RedundantModifier Redundant 'final' modifier. 88
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 88
 Error misc FinalParameters Parameter file should be final. 88
 Error misc FinalParameters Parameter startPosition should be final. 88
 Error misc FinalParameters Parameter sampleTimeMs should be final. 89
 Error misc FinalParameters Parameter chunkSize should be final. 89
 Error misc FinalParameters Parameter events should be final. 89
 Error javadoc JavadocMethod Expected @param tag for 'events'. 89
 Error regexp RegexpSingleline Line has trailing spaces. 104
 Error javadoc JavadocMethod Expected an @return tag. 115
 Error sizes LineLength Line is longer than 80 characters (found 86). 115
 Error modifier RedundantModifier Redundant 'final' modifier. 115
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 115
 Error misc FinalParameters Parameter file should be final. 115
 Error misc FinalParameters Parameter startPosition should be final. 115
 Error misc FinalParameters Parameter sampleTimeMs should be final. 116
 Error misc FinalParameters Parameter charset should be final. 116
 Error sizes LineLength Line is longer than 80 characters (found 99). 117
 Error regexp RegexpSingleline Line has trailing spaces. 125
 Error javadoc JavadocMethod Expected an @return tag. 137
 Error sizes LineLength Line is longer than 80 characters (found 86). 137
 Error modifier RedundantModifier Redundant 'final' modifier. 137
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 137
 Error misc FinalParameters Parameter file should be final. 137
 Error misc FinalParameters Parameter startPosition should be final. 137
 Error misc FinalParameters Parameter chunkSize should be final. 138
 Error javadoc JavadocMethod Expected @param tag for 'chunkSize'. 138
 Error misc FinalParameters Parameter charset should be final. 138
 Error misc FinalParameters Parameter events should be final. 138
 Error sizes LineLength Line is longer than 80 characters (found 90). 139
 Error regexp RegexpSingleline Line has trailing spaces. 146
 Error javadoc JavadocMethod Expected an @return tag. 151
 Error sizes LineLength Line is longer than 80 characters (found 83). 151
 Error modifier RedundantModifier Redundant 'final' modifier. 151
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 151
 Error misc FinalParameters Parameter watchService should be final. 151
 Error sizes LineLength Line is longer than 80 characters (found 83). 152
 Error regexp RegexpSingleline Line has trailing spaces. 164
 Error javadoc JavadocMethod Expected an @return tag. 171
 Error sizes LineLength Line is longer than 80 characters (found 91). 172
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 172
 Error misc FinalParameters Parameter kinds should be final. 172
 Error regexp RegexpSingleline Line has trailing spaces. 184
 Error javadoc JavadocMethod Expected an @return tag. 191
 Error modifier RedundantModifier Redundant 'final' modifier. 191
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 191
 Error javadoc JavadocMethod Expected @param tag for 'file'. 191
 Error misc FinalParameters Parameter kinds should be final. 192
 Error javadoc JavadocMethod Expected @param tag for 'kinds'. 192
 Error misc FinalParameters Parameter w should be final. 197
 Error blocks NeedBraces 'if' construct must use '{}'s. 198
 Error regexp RegexpSingleline Line has trailing spaces. 211
 Error javadoc JavadocMethod Expected an @return tag. 218
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 219
 Error sizes LineLength Line is longer than 80 characters (found 87). 227
 Error javadoc JavadocMethod Missing a Javadoc comment. 238
 Error modifier RedundantModifier Redundant 'final' modifier. 238
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 238
 Error blocks NeedBraces 'if' construct must use '{}'s. 240
 Error blocks NeedBraces 'else' construct must use '{}'s. 242
 Error regexp RegexpSingleline Line has trailing spaces. 251
 Error javadoc JavadocMethod Expected an @return tag. 256
 Error sizes LineLength Line is longer than 80 characters (found 87). 256
 Error modifier RedundantModifier Redundant 'final' modifier. 256
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 256
 Error misc FinalParameters Parameter event should be final. 260
 Error blocks NeedBraces 'if' construct must use '{}'s. 263
 Error blocks NeedBraces 'if' construct must use '{}'s. 265
 Error sizes LineLength Line is longer than 80 characters (found 84). 273
 Error blocks NeedBraces 'else' construct must use '{}'s. 274
 Error sizes LineLength Line is longer than 80 characters (found 90). 282
 Error javadoc JavadocMethod Missing a Javadoc comment. 282
 Error misc FinalParameters Parameter bytes should be final. 282
 Error misc FinalParameters Parameter charset should be final. 282
 Error sizes LineLength Line is longer than 80 characters (found 144). 286
 Error javadoc JavadocVariable Missing a Javadoc comment. 286
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 286
 Error misc FinalParameters Parameter watchService should be final. 289
 Error sizes LineLength Line is longer than 80 characters (found 92). 294
 Error javadoc JavadocMethod Missing a Javadoc comment. 294
 Error misc FinalParameters Parameter events should be final. 294
 Error sizes LineLength Line is longer than 80 characters (found 84). 303
 Error javadoc JavadocMethod Missing a Javadoc comment. 303
 Error misc FinalParameters Parameter group should be final. 308
 Error blocks NeedBraces 'if' construct must use '{}'s. 310
 Error blocks NeedBraces 'else' construct must use '{}'s. 312
 Error sizes LineLength Line is longer than 80 characters (found 96). 318
 Error javadoc JavadocVariable Missing a Javadoc comment. 318
 Error naming StaticVariableName Name 'IS_MODIFY_OR_OVERFLOW' must match pattern '^[a-z][a-zA-Z0-9]*$'. 318
 Error misc FinalParameters Parameter event should be final. 321
 Error coding SimplifyBooleanReturn Conditional logic can be removed. 325
 Error sizes LineLength Line is longer than 80 characters (found 82). 326
 Error blocks NeedBraces 'else' construct must use '{}'s. 328
 Error blocks NeedBraces 'else' construct must use '{}'s. 330
 Error javadoc JavadocMethod Missing a Javadoc comment. 335
 Error design FinalClass Class Builder should be declared as final. 339
 Error javadoc JavadocType Missing a Javadoc comment. 339
 Error javadoc JavadocVariable Missing a Javadoc comment. 341
 Error javadoc JavadocVariable Missing a Javadoc comment. 342
 Error javadoc JavadocVariable Missing a Javadoc comment. 343
 Error coding MagicNumber '500' is a magic number. 343
 Error javadoc JavadocVariable Missing a Javadoc comment. 344
 Error coding MagicNumber '8192' is a magic number. 344
 Error javadoc JavadocVariable Missing a Javadoc comment. 345
 Error javadoc JavadocVariable Missing a Javadoc comment. 346
 Error javadoc JavadocVariable Missing a Javadoc comment. 347
 Error javadoc JavadocMethod Missing a Javadoc comment. 354
 Error regexp RegexpSingleline Line has trailing spaces. 359
 Error misc FinalParameters Parameter file should be final. 363
 Error coding HiddenField 'file' hides a field. 363
 Error javadoc JavadocMethod Expected @param tag for 'file'. 363
 Error javadoc JavadocMethod Missing a Javadoc comment. 368
 Error misc FinalParameters Parameter filename should be final. 368
 Error javadoc JavadocMethod Missing a Javadoc comment. 372
 Error misc FinalParameters Parameter onWatchStarted should be final. 372
 Error coding HiddenField 'onWatchStarted' hides a field. 372
 Error regexp RegexpSingleline Line has trailing spaces. 380
 Error misc FinalParameters Parameter startPosition should be final. 384
 Error coding HiddenField 'startPosition' hides a field. 384
 Error javadoc JavadocMethod Expected @param tag for 'startPosition'. 384
 Error regexp RegexpSingleline Line has trailing spaces. 395
 Error misc FinalParameters Parameter sampleTimeMs should be final. 399
 Error coding HiddenField 'sampleTimeMs' hides a field. 399
 Error javadoc JavadocMethod Expected @param tag for 'sampleTimeMs'. 399
 Error regexp RegexpSingleline Line has trailing spaces. 406
 Error misc FinalParameters Parameter chunkSize should be final. 410
 Error coding HiddenField 'chunkSize' hides a field. 410
 Error javadoc JavadocMethod Expected @param tag for 'chunkSize'. 410
 Error regexp RegexpSingleline Line has trailing spaces. 417
 Error misc FinalParameters Parameter charset should be final. 421
 Error coding HiddenField 'charset' hides a field. 421
 Error javadoc JavadocMethod Expected @param tag for 'charset'. 421
 Error regexp RegexpSingleline Line has trailing spaces. 428
 Error misc FinalParameters Parameter charset should be final. 432
 Error coding HiddenField 'charset' hides a field. 432
 Error javadoc JavadocMethod Expected @param tag for 'charset'. 432
 Error javadoc JavadocMethod Missing a Javadoc comment. 436
 Error javadoc JavadocMethod Missing a Javadoc comment. 440
 Error misc FinalParameters Parameter source should be final. 440
 Error coding HiddenField 'source' hides a field. 440
 Error javadoc JavadocMethod Missing a Javadoc comment. 445
 Error sizes LineLength Line is longer than 80 characters (found 87). 447
 Error javadoc JavadocMethod Missing a Javadoc comment. 450
 Error sizes LineLength Line is longer than 80 characters (found 86). 451
 Error javadoc JavadocMethod Missing a Javadoc comment. 454
 Error blocks NeedBraces 'if' construct must use '{}'s. 455
 Error sizes LineLength Line is longer than 80 characters (found 87). 456
 Error sizes LineLength Line is longer than 80 characters (found 96). 457
 Error blocks NeedBraces 'else' construct must use '{}'s. 458

com/github/davidmoten/rx/FileObservableTest.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 37
 Error design DesignForExtension Method 'testNoEventsThrownIfFileDoesNotExist' is not designed for extension - needs to be abstract, final or empty. 39
 Error javadoc JavadocMethod Missing a Javadoc comment. 39
 Error sizes LineLength Line is longer than 80 characters (found 84). 40
 Error sizes LineLength Line is longer than 80 characters (found 83). 42
 Error misc FinalParameters Parameter e should be final. 53
 Error misc FinalParameters Parameter arg0 should be final. 59
 Error coding MagicNumber '100' is a magic number. 63
 Error design DesignForExtension Method 'testCreateAndModifyEventsForANonDirectoryFile' is not designed for extension - needs to be abstract, final or empty. 67
 Error javadoc JavadocMethod Missing a Javadoc comment. 67
 Error sizes LineLength Line is longer than 80 characters (found 97). 72
 Error misc FinalParameters Parameter e should be final. 87
 Error misc FinalParameters Parameter event should be final. 92
 Error coding MagicNumber '1000' is a magic number. 99
 Error coding MagicNumber '100' is a magic number. 105
 Error coding MagicNumber '30000' is a magic number. 106
 Error coding MagicNumber '100' is a magic number. 112
 Error design DesignForExtension Method 'testFileTailingFromStartOfFile' is not designed for extension - needs to be abstract, final or empty. 116
 Error javadoc JavadocMethod Missing a Javadoc comment. 116
 Error sizes LineLength Line is longer than 80 characters (found 91). 117
 Error sizes LineLength Line is longer than 80 characters (found 100). 123
 Error coding MagicNumber '50' is a magic number. 129
 Error sizes LineLength Line is longer than 80 characters (found 96). 132
 Error misc FinalParameters Parameter line should be final. 134
 Error coding MagicNumber '10' is a magic number. 140
 Error design DesignForExtension Method 'testFileTailingWhenFileIsCreatedAfterSubscription' is not designed for extension - needs to be abstract, final or empty. 145
 Error javadoc JavadocMethod Missing a Javadoc comment. 145
 Error sizes LineLength Line is longer than 80 characters (found 86). 152
 Error coding MagicNumber '50' is a magic number. 153
 Error sizes LineLength Line is longer than 80 characters (found 96). 168
 Error misc FinalParameters Parameter line should be final. 170
 Error coding MagicNumber '10' is a magic number. 176
 Error javadoc JavadocMethod Missing a Javadoc comment. 181
 Error misc FinalParameters Parameter file should be final. 181
 Error misc FinalParameters Parameter line should be final. 181
 Error design DesignForExtension Method 'testTailTextFileStreamsFromEndOfFileIfSpecified' is not designed for extension - needs to be abstract, final or empty. 194
 Error javadoc JavadocMethod Missing a Javadoc comment. 194
 Error sizes LineLength Line is longer than 80 characters (found 95). 204
 Error coding MagicNumber '10' is a magic number. 204
 Error misc FinalParameters Parameter line should be final. 210
 Error coding MagicNumber '1100' is a magic number. 215
 Error sizes LineLength Line is longer than 80 characters (found 83). 217
 Error coding MagicNumber '1100' is a magic number. 220
 Error design DesignForExtension Method 'testTailTextFileStreamsFromEndOfFileIfDeleteOccurs' is not designed for extension - needs to be abstract, final or empty. 226
 Error javadoc JavadocMethod Missing a Javadoc comment. 226
 Error sizes LineLength Line is longer than 80 characters (found 90). 235
 Error coding MagicNumber '10' is a magic number. 236
 Error misc FinalParameters Parameter line should be final. 241
 Error coding MagicNumber '1100' is a magic number. 248
 Error sizes LineLength Line is longer than 80 characters (found 83). 252
 Error coding MagicNumber '1100' is a magic number. 256

com/github/davidmoten/rx/SampleTest.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 15
 Error design DesignForExtension Method 'testSampleDoesNotRepeatEmissions' is not designed for extension - needs to be abstract, final or empty. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error coding MagicNumber '100' is a magic number. 24
 Error misc FinalParameters Parameter n should be final. 28
 Error coding MagicNumber '3' is a magic number. 35
 Error coding MagicNumber '250' is a magic number. 38
 Error coding MagicNumber '3' is a magic number. 42

com/github/davidmoten/rx/operators/OperatorFileTailer.java

Severity Category Rule Message Line
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error javadoc JavadocVariable Missing a Javadoc comment. 29
 Error javadoc JavadocVariable Missing a Javadoc comment. 30
 Error regexp RegexpSingleline Line has trailing spaces. 34
 Error sizes LineLength Line is longer than 80 characters (found 87). 40
 Error misc FinalParameters Parameter file should be final. 40
 Error coding HiddenField 'file' hides a field. 40
 Error misc FinalParameters Parameter startPosition should be final. 40
 Error misc FinalParameters Parameter maxBytesPerEmission should be final. 40
 Error coding HiddenField 'maxBytesPerEmission' hides a field. 40
 Error javadoc JavadocMethod Expected @param tag for 'maxBytesPerEmission'. 40
 Error blocks NeedBraces 'if' construct must use '{}'s. 41
 Error regexp RegexpSingleline Line has trailing spaces. 50
 Error misc FinalParameters Parameter file should be final. 54
 Error coding HiddenField 'file' hides a field. 54
 Error javadoc JavadocMethod Expected @param tag for 'file'. 54
 Error misc FinalParameters Parameter startPosition should be final. 54
 Error javadoc JavadocMethod Expected @param tag for 'startPosition'. 54
 Error coding MagicNumber '8192' is a magic number. 55
 Error design DesignForExtension Method 'call' is not designed for extension - needs to be abstract, final or empty. 58
 Error misc FinalParameters Parameter child should be final. 59
 Error sizes LineLength Line is longer than 80 characters (found 101). 60
 Error sizes LineLength Line is longer than 80 characters (found 86). 66
 Error sizes LineLength Line is longer than 80 characters (found 84). 72
 Error javadoc JavadocMethod Missing a Javadoc comment. 72
 Error misc FinalParameters Parameter event should be final. 76
 Error sizes LineLength Line is longer than 80 characters (found 83). 81
 Error misc FinalParameters Parameter t1 should be final. 101
 Error misc FinalParameters Parameter bytes should be final. 106
 Error misc FinalParameters Parameter is should be final. 113
 Error blocks EmptyBlock Must have at least one statement. 116
 Error blocks NeedBraces 'else' construct must use '{}'s. 124

com/github/davidmoten/rx/operators/OperatorFileTailerTest.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 5
 Error javadoc JavadocMethod Missing a Javadoc comment. 7

com/github/davidmoten/rx/operators/OperatorWatchServiceEvents.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error sizes LineLength Line is longer than 80 characters (found 90). 19
 Error design DesignForExtension Method 'call' is not designed for extension - needs to be abstract, final or empty. 21
 Error sizes LineLength Line is longer than 80 characters (found 102). 22
 Error sizes LineLength Line is longer than 80 characters (found 89). 23
 Error misc FinalParameters Parameter e should be final. 31
 Error misc FinalParameters Parameter watchService should be final. 36
 Error sizes LineLength Line is longer than 80 characters (found 100). 40
 Error sizes LineLength Line is longer than 80 characters (found 108). 43
 Error sizes LineLength Line is longer than 80 characters (found 107). 51
 Error javadoc JavadocMethod Missing a Javadoc comment. 51
 Error misc FinalParameters Parameter watchService should be final. 51
 Error misc FinalParameters Parameter subscriber should be final. 51
 Error misc FinalParameters Parameter subscribed should be final. 52
 Error blocks NeedBraces 'if' construct must use '{}'s. 57
 Error blocks NeedBraces 'if' construct must use '{}'s. 62
 Error blocks NeedBraces 'else' construct must use '{}'s. 64
 Error blocks NeedBraces 'if' construct must use '{}'s. 72
 Error sizes LineLength Line is longer than 80 characters (found 108). 79
 Error javadoc JavadocMethod Missing a Javadoc comment. 79
 Error misc FinalParameters Parameter watchService should be final. 79
 Error misc FinalParameters Parameter subscriber should be final. 79
 Error misc FinalParameters Parameter subscribed should be final. 80
 Error blocks NeedBraces 'if' construct must use '{}'s. 87
 Error blocks EmptyBlock Must have at least one statement. 105
 Error sizes LineLength Line is longer than 80 characters (found 108). 112
 Error javadoc JavadocMethod Missing a Javadoc comment. 112
 Error modifier RedundantModifier Redundant 'final' modifier. 112
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 112
 Error sizes LineLength Line is longer than 80 characters (found 97). 113
 Error blocks EmptyBlock Must have at least one statement. 120
 Error blocks EmptyBlock Must have at least one statement. 122