Checkstyle Results

The following document contains the results of Checkstyle 8.29 with sun_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
4 0 0 121

Files

File
 I
 W
 E
com/github/davidmoten/xuml/MyEdgeLabelRenderer.java 0 0 37
com/github/davidmoten/xuml/Panels.java 0 0 17
com/github/davidmoten/xuml/StateDiagramViewer.java 0 0 62
com/github/davidmoten/xuml/StateDiagramViewerTestMain.java 0 0 5

Rules

Category Rule Violations Severity
blocks NeedBraces 10
 Error
coding HiddenField 4
 Error
MagicNumber 13
 Error
SimplifyBooleanExpression 1
 Error
design DesignForExtension 5
 Error
HideUtilityClassConstructor 2
 Error
VisibilityModifier 1
 Error
javadoc JavadocPackage 2
 Error
JavadocVariable 7
 Error
MissingJavadocMethod 10
 Error
misc FinalParameters 31
 Error
NewlineAtEndOfFile 2
 Error
modifier ModifierOrder 1
 Error
naming ConstantName 1
 Error
sizes LineLength
  • fileExtensions: "java"
 25
 Error
whitespace GenericWhitespace 6
 Error

Details

com/github/davidmoten/xuml/MyEdgeLabelRenderer.java

Severity Category Rule Message Line
 Error		 javadoc JavadocPackage Missing package-info.java file. 1
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 32
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 33
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 35
 Error		 misc FinalParameters Parameter unaryEdgeDeltaY should be final. 35
 Error		 coding HiddenField 'unaryEdgeDeltaY' hides a field. 35
 Error		 misc FinalParameters Parameter bgColor should be final. 35
 Error		 coding HiddenField 'bgColor' hides a field. 35
 Error		 sizes LineLength Line is longer than 80 characters (found 98). 40
 Error		 design DesignForExtension Class 'MyEdgeLabelRenderer' looks like designed for extension (can be subclassed), but the method 'prepareRenderer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyEdgeLabelRenderer' final or making the method 'prepareRenderer' static/final/abstract/empty, or adding allowed annotation for the method. 40
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 40
 Error		 misc FinalParameters Parameter rc should be final. 40
 Error		 misc FinalParameters Parameter graphLabelRenderer should be final. 40
 Error		 misc FinalParameters Parameter value should be final. 41
 Error		 misc FinalParameters Parameter isSelected should be final. 41
 Error		 misc FinalParameters Parameter edge should be final. 41
 Error		 sizes LineLength Line is longer than 80 characters (found 96). 42
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 42
 Error		 sizes LineLength Line is longer than 80 characters (found 82). 43
 Error		 design DesignForExtension Class 'MyEdgeLabelRenderer' looks like designed for extension (can be subclassed), but the method 'labelEdge' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyEdgeLabelRenderer' final or making the method 'labelEdge' static/final/abstract/empty, or adding allowed annotation for the method. 46
 Error		 sizes LineLength Line is longer than 80 characters (found 91). 47
 Error		 misc FinalParameters Parameter rc should be final. 47
 Error		 misc FinalParameters Parameter layout should be final. 47
 Error		 misc FinalParameters Parameter e should be final. 47
 Error		 misc FinalParameters Parameter label should be final. 47
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 48
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 56
 Error		 sizes LineLength Line is longer than 80 characters (found 96). 56
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 56
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 59
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 60
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 62
 Error		 sizes LineLength Line is longer than 80 characters (found 85). 80
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 80
 Error		 sizes LineLength Line is longer than 80 characters (found 81). 86
 Error		 sizes LineLength Line is longer than 80 characters (found 83). 88
 Error		 whitespace GenericWhitespace '>' is followed by whitespace. 94

com/github/davidmoten/xuml/Panels.java

Severity Category Rule Message Line
 Error		 design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 19
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 21
 Error		 misc FinalParameters Parameter panel should be final. 21
 Error		 misc FinalParameters Parameter file should be final. 21
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 31
 Error		 misc FinalParameters Parameter panel should be final. 31
 Error		 misc FinalParameters Parameter os should be final. 31
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 46
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 51
 Error		 sizes LineLength Line is longer than 80 characters (found 87). 51
 Error		 blocks NeedBraces 'else' construct must use '{}'s. 53
 Error		 misc FinalParameters Parameter pg should be final. 58
 Error		 misc FinalParameters Parameter pf should be final. 58
 Error		 misc FinalParameters Parameter pageNum should be final. 58
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 59
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 83
 Error		 coding SimplifyBooleanExpression Expression can be simplified. 83

com/github/davidmoten/xuml/StateDiagramViewer.java

Severity Category Rule Message Line
 Error		 misc NewlineAtEndOfFile File does not end with a newline. 1
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 42
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 43
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 44
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 46
 Error		 modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 46
 Error		 naming ConstantName Name 'state' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 46
 Error		 misc FinalParameters Parameter domain should be final. 48
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 49
 Error		 sizes LineLength Line is longer than 80 characters (found 88). 50
 Error		 design DesignForExtension Class 'StateDiagramViewer' looks like designed for extension (can be subclassed), but the method 'show' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StateDiagramViewer' final or making the method 'show' static/final/abstract/empty, or adding allowed annotation for the method. 64
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 64
 Error		 misc FinalParameters Parameter c should be final. 64
 Error		 sizes LineLength Line is longer than 80 characters (found 96). 68
 Error		 coding HiddenField 'state' hides a field. 68
 Error		 sizes LineLength Line is longer than 80 characters (found 96). 72
 Error		 sizes LineLength Line is longer than 80 characters (found 87). 73
 Error		 coding MagicNumber '1000' is a magic number. 120
 Error		 coding MagicNumber '800' is a magic number. 120
 Error		 blocks NeedBraces 'if' construct must use '{}'s. 133
 Error		 coding MagicNumber '800' is a magic number. 163
 Error		 coding MagicNumber '600' is a magic number. 163
 Error		 javadoc JavadocVariable Missing a Javadoc comment. 170
 Error		 design VisibilityModifier Variable 'name' must be private and have accessor methods. 170
 Error		 misc FinalParameters Parameter name should be final. 172
 Error		 coding HiddenField 'name' hides a field. 172
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 176
 Error		 misc FinalParameters Parameter name should be final. 176
 Error		 misc FinalParameters Parameter graph should be final. 186
 Error		 sizes LineLength Line is longer than 80 characters (found 99). 187
 Error		 coding MagicNumber '800' is a magic number. 187
 Error		 coding MagicNumber '600' is a magic number. 187
 Error		 blocks NeedBraces 'while' construct must use '{}'s. 188
 Error		 sizes LineLength Line is longer than 80 characters (found 92). 191
 Error		 coding MagicNumber '800' is a magic number. 192
 Error		 coding MagicNumber '600' is a magic number. 192
 Error		 misc FinalParameters Parameter g should be final. 197
 Error		 sizes LineLength Line is longer than 80 characters (found 94). 209
 Error		 sizes LineLength Line is longer than 80 characters (found 83). 211
 Error		 sizes LineLength Line is longer than 80 characters (found 94). 212
 Error		 sizes LineLength Line is longer than 80 characters (found 98). 213
 Error		 sizes LineLength Line is longer than 80 characters (found 85). 214
 Error		 sizes LineLength Line is longer than 80 characters (found 82). 215
 Error		 sizes LineLength Line is longer than 80 characters (found 91). 216
 Error		 coding MagicNumber '-10' is a magic number. 216
 Error		 sizes LineLength Line is longer than 80 characters (found 111). 220
 Error		 misc FinalParameters Parameter layout should be final. 227
 Error		 coding MagicNumber '150' is a magic number. 229
 Error		 coding MagicNumber '5' is a magic number. 230
 Error		 coding MagicNumber '12' is a magic number. 231
 Error		 coding MagicNumber '5' is a magic number. 232
 Error		 sizes LineLength Line is longer than 80 characters (found 90). 233
 Error		 misc FinalParameters Parameter f should be final. 243
 Error		 design DesignForExtension Class 'StateDiagramViewer' looks like designed for extension (can be subclassed), but the method 'start' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StateDiagramViewer' final or making the method 'start' static/final/abstract/empty, or adding allowed annotation for the method. 257
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 257
 Error		 misc FinalParameters Parameter resource should be final. 257
 Error		 misc FinalParameters Parameter domainName should be final. 257
 Error		 sizes LineLength Line is longer than 80 characters (found 82). 258
 Error		 design DesignForExtension Class 'StateDiagramViewer' looks like designed for extension (can be subclassed), but the method 'start' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StateDiagramViewer' final or making the method 'start' static/final/abstract/empty, or adding allowed annotation for the method. 261
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 261
 Error		 misc FinalParameters Parameter input should be final. 261
 Error		 misc FinalParameters Parameter domainName should be final. 261

com/github/davidmoten/xuml/StateDiagramViewerTestMain.java

Severity Category Rule Message Line
 Error		 misc NewlineAtEndOfFile File does not end with a newline. 1
 Error		 javadoc JavadocPackage Missing package-info.java file. 1
 Error		 design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 5
 Error		 javadoc MissingJavadocMethod Missing a Javadoc comment. 7
 Error		 misc FinalParameters Parameter args should be final. 7